Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

%3D separator for keywords #628

Merged
merged 4 commits into from
Dec 9, 2024
Merged

%3D separator for keywords #628

merged 4 commits into from
Dec 9, 2024
+2,098 −1,386

Conversation

babenek
Copy link
Contributor

@babenek babenek commented Dec 5, 2024 •
edited
Loading

Description

Please include a summary of the change and which is fixed.

  • Add %3D separator for keywords in URL
  • Fix URL cleanup for the case and other HTML escaped sequences
  • changed tests samples and data

How has this been tested?

Please describe the tests that you ran to verify your changes.

  • UnitTest
  • Benchmark

@babenek babenek changed the title 3d %3D separator for keywords Dec 5, 2024
babenek
babenek commented Dec 9, 2024
View reviewed changes
Dockerfile Outdated Show resolved Hide resolved
@babenek babenek marked this pull request as ready for review December 9, 2024 12:56
@babenek babenek requested a review from a team as a code owner December 9, 2024 12:56
Yullia
Yullia approved these changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@Yullia Yullia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@babenek babenek merged commit 84a5ed8 into Samsung:main Dec 9, 2024
32 checks passed
@babenek babenek deleted the 3d branch December 9, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iuriimet iuriimet iuriimet approved these changes

@Yullia Yullia Yullia approved these changes

@xDizzix xDizzix Awaiting requested review from xDizzix

@csh519 csh519 Awaiting requested review from csh519

@kmnls kmnls Awaiting requested review from kmnls

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@babenek @Yullia @iuriimet